Fix: Query param deepObject return without assign on !required#68
Merged
mromaszewicz merged 3 commits intooapi-codegen:mainfrom Mar 18, 2026
Merged
Conversation
|
@jamietanna sorry for a direct ping, it's been almost a year, may I ask for your review? |
Exercise the required and optional code paths for deepObject-style query parameters to verify no unintended side effects from PR oapi-codegen#68. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mromaszewicz
approved these changes
Mar 18, 2026
Member
|
Thanks for doing this, and sorry about the long delays. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
BindQueryParameterto return error if query param was not provided but was set as requiredUpdated
UnmarshalDeepObjectto skip value assign if query param was not provided and not requiredFixes #67